Support request byValue and byReference and presentationDefinition #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulledtim
reviewed
May 6, 2025
pulledtim
reviewed
May 6, 2025
pulledtim
reviewed
May 6, 2025
pulledtim
reviewed
May 6, 2025
| The object than can be retrived via: | ||
| ```shell | ||
| curl https://verifier.org/api/v1/request/randomState | ||
| ``` |
There was a problem hiding this comment.
Would it help to show an example value of the retrieved data here?
There was a problem hiding this comment.
Hm, I left it out, since its the same as in the line before.
pulledtim
reviewed
May 6, 2025
pulledtim
reviewed
May 6, 2025
pulledtim
reviewed
May 6, 2025
pulledtim
reviewed
May 6, 2025
pulledtim
reviewed
May 6, 2025
pulledtim
reviewed
May 6, 2025
|
|
||
| didSigningKey, err := getRequestSigningKey(verifierConfig.ClientIdentification.KeyPath, verifierConfig.ClientIdentification.Id) | ||
| if (slices.Contains(verifierConfig.SupportedModes, REQUEST_MODE_BY_VALUE) || slices.Contains(verifierConfig.SupportedModes, REQUEST_MODE_BY_REFERENCE)) && err != nil { | ||
| logging.Log().Errorf("Was not able to get a signing key, despite mode %s supported. Err: %v", REQUEST_MODE_BY_VALUE, err) |
There was a problem hiding this comment.
Would it make sense to wrap the error with the additional description and return it?
There was a problem hiding this comment.
I think since the log already is on error, it should be enough to return the root
pulledtim
reviewed
May 6, 2025
pulledtim
reviewed
May 6, 2025
pulledtim
reviewed
May 6, 2025
pulledtim
reviewed
May 6, 2025
Co-authored-by: Tim Smyth <[email protected]>
Co-authored-by: Tim Smyth <[email protected]>
Co-authored-by: Tim Smyth <[email protected]>
Co-authored-by: Tim Smyth <[email protected]>
Co-authored-by: Tim Smyth <[email protected]>
Co-authored-by: Tim Smyth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires CredentialConfigService > 3.x